m1saka
66abb76318
Close all 14 findings from the codebase audit (1 high, 5 medium, 8 low): - Locking: replace the global API and workspace mutexes with per-instance and per-user keyed locks (new internal/api/locks.go) so a slow restore, upgrade or transfer no longer blocks unrelated users or instances; move Docker I/O out of the build queue and invalidate concurrent image-index observations with a generation counter; serialize instance deletion behind in-flight creation. - Security: equalize login timing for unknown usernames, periodically purge expired sessions/refresh tokens/lock rows, URL-encode orphan IDs in the frontend, upgrade vitest 3.x->5.x to clear 3 npm audit vulnerabilities (2 critical RCE). - Deployment: add a -healthcheck mode probing /healthz (used by Dockerfile HEALTHCHECK and compose), make ADMIN_PASSWORD optional in compose with removal guidance after first start, exclude test scripts from the image, and cap panel resources (cpus: 2, pids_limit: 512). - Reliability: check rows.Err() on admin listing loops, surface intent polling errors without sticking, disable close during in-flight create. Verified: go build/vet, full go test -race -count=1 ./..., frontend tsc build + 32 tests, npm audit 0, compose config, real-container healthcheck.
50 lines
1.6 KiB
YAML
50 lines
1.6 KiB
YAML
services:
|
|
panel:
|
|
container_name: dsh-mgr-panel
|
|
build: .
|
|
image: dsh-mgr:local
|
|
restart: unless-stopped
|
|
stop_grace_period: 20s
|
|
user: "1000:1000"
|
|
group_add:
|
|
- ${DOCKER_GID:?Set the numeric group ID of the Docker socket}
|
|
ports:
|
|
- '127.0.0.1:8088:8088'
|
|
environment:
|
|
LISTEN_ADDR: 0.0.0.0:8088
|
|
DATA_ROOT: /data
|
|
CONTAINER_DATA_ROOT: /data
|
|
HOST_DATA_ROOT: ${DSH_HOST_DATA_ROOT:?Set an absolute host data directory}
|
|
PANEL_PUBLIC_URL: ${PANEL_PUBLIC_URL:-http://127.0.0.1:8088}
|
|
TRUSTED_PROXY_CIDRS: ${TRUSTED_PROXY_CIDRS:-}
|
|
WEB_DIR: /app/web/dist
|
|
UPLOAD_ALLOWED_EXTENSIONS: ${UPLOAD_ALLOWED_EXTENSIONS:-}
|
|
ADMIN_USERNAME: ${DSH_ADMIN_USERNAME:-admin}
|
|
# Read only on first startup while the user table is empty; remove the
|
|
# value from .env afterwards so the plaintext password is not retained.
|
|
ADMIN_PASSWORD: ${DSH_ADMIN_PASSWORD:-}
|
|
DOCKER_HOST: unix:///var/run/docker.sock
|
|
DSH_DOCKER_ROOT_VISIBLE: ${DSH_DOCKER_ROOT_DIR:?Set the exact DockerRootDir reported by docker info}
|
|
PANEL_CONTAINER_ID: dsh-mgr-panel
|
|
volumes:
|
|
- ${DSH_HOST_DATA_ROOT}:/data
|
|
- /var/run/docker.sock:/var/run/docker.sock
|
|
- ${DSH_DOCKER_ROOT_DIR}:${DSH_DOCKER_ROOT_DIR}:ro
|
|
read_only: true
|
|
tmpfs:
|
|
- /tmp:size=256m
|
|
mem_limit: 1g
|
|
cpus: 2
|
|
pids_limit: 512
|
|
healthcheck:
|
|
test: ["CMD", "/usr/local/bin/dsh-mgr", "-healthcheck"]
|
|
interval: 30s
|
|
timeout: 5s
|
|
retries: 3
|
|
start_period: 15s
|
|
logging:
|
|
driver: json-file
|
|
options:
|
|
max-size: 10m
|
|
max-file: '3'
|