fix: preserve logger byte reservations

This commit is contained in:
MiMoCode
2026-07-10 18:33:27 +08:00
parent 044bed77e6
commit 8eaab5ccfb
2 changed files with 46 additions and 11 deletions
+20 -11
View File
@@ -54,9 +54,14 @@ type FlushResult struct {
Err error
}
type queuedEntry struct {
entry *LogEntry
size int64
}
// Queue is an asynchronous, bounded logger. Submit never waits for database work.
type Queue struct {
ch chan *LogEntry
ch chan queuedEntry
pool *db.Pool
batchSize int
batchInterval time.Duration
@@ -101,7 +106,7 @@ func NewQueue(pool *db.Pool, queueSize, batchSize, workers int, batchInterval ti
batchInterval = time.Second
}
return &Queue{
ch: make(chan *LogEntry, queueSize),
ch: make(chan queuedEntry, queueSize),
pool: pool,
batchSize: batchSize,
batchInterval: batchInterval,
@@ -210,7 +215,7 @@ func (q *Queue) Submit(e *LogEntry) {
return
}
select {
case q.ch <- e:
case q.ch <- queuedEntry{entry: e, size: size}:
q.enq.Add(1)
default:
q.release(size)
@@ -252,15 +257,15 @@ func (q *Queue) release(size int64) {
}
func (q *Queue) discardQueued() {
for e := range q.ch {
q.release(EstimatedBytes(e))
for item := range q.ch {
q.release(item.size)
q.failed.Add(1)
}
}
func (q *Queue) run(workCtx context.Context) {
defer q.wg.Done()
batch := make([]*LogEntry, 0, q.batchSize)
batch := make([]queuedEntry, 0, q.batchSize)
ticker := time.NewTicker(q.batchInterval)
defer ticker.Stop()
@@ -268,9 +273,13 @@ func (q *Queue) run(workCtx context.Context) {
if len(batch) == 0 {
return
}
q.flush(q.flushContext(workCtx), batch)
for _, e := range batch {
q.release(EstimatedBytes(e))
entries := make([]*LogEntry, len(batch))
for i, item := range batch {
entries[i] = item.entry
}
q.flush(q.flushContext(workCtx), entries)
for _, item := range batch {
q.release(item.size)
}
clear(batch)
batch = batch[:0]
@@ -278,12 +287,12 @@ func (q *Queue) run(workCtx context.Context) {
for {
select {
case e, ok := <-q.ch:
case item, ok := <-q.ch:
if !ok {
flush()
return
}
batch = append(batch, e)
batch = append(batch, item)
if len(batch) >= q.batchSize {
flush()
}